-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default target storage in etcd #41065
Default target storage in etcd #41065
Conversation
[APPROVALNOTIFIER] This PR is APPROVED The following people have approved this PR: wojtek-t Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Please add more context in the PR description. It's unclear to people without context what this PR is supposed to fix. |
@fgrzadkowski - added description. PTAL |
sed -i -e "s@{{ *storage_backend *}}@${STORAGE_BACKEND:-}@g" "${temp_file}" | ||
if [[ "${STORAGE_BACKEND:-}" == "etcd3" ]]; then | ||
if [[ "${STORAGE_BACKEND:-etcd3}" == "etcd3" ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this. Shouldn't we just default STORAGE_BACKEND to etcdv3 in one place, rather than default it in all the places where you'd use it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I understand this one.
However it means that the default you have here has to be inline with whatever you set as the default in manifest file. Is there anyway we can just read the default value from manifest file using sed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do it using "grep + sed". Will fix. (I agree it makes sense, especially since we are touching the same manifest file here).
ab179a9
to
2bd2cf7
Compare
2bd2cf7
to
a2a861b
Compare
@wojtek-t: The following test(s) failed:
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@k8s-bot cross build test this, issue: #IGNORE (timeout) |
@fgrzadkowski - PTAL |
/lgtm |
I thought I'd clicked "Send" on my review yesterday, but I guess I did not. My only comment was the same as @fgrzadkowski's. |
Automatic merge from submit-queue (batch tested with PRs 40873, 40948, 39580, 41065, 40815) |
To make etcd v2->v3 upgrade work correctly, we need to correctly set the "TARGET_STORAGE" env var. Since in head we are defaulting to etcd v3, this PR is defaulting also that env var to etcd3, so that by default upgrade works fine.
@fgrzadkowski @gmarek